Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update findField function #52

Merged
merged 3 commits into from
Jul 12, 2024
Merged

Update findField function #52

merged 3 commits into from
Jul 12, 2024

Conversation

vitPinchuk
Copy link
Contributor

@vitPinchuk vitPinchuk commented Jul 12, 2024 •
edited
Loading

add frame argument to predicate function
per resolve issue : 127

@vitPinchuk vitPinchuk self-assigned this Jul 12, 2024
@vitPinchuk vitPinchuk requested a review from asimonok July 12, 2024 07:30
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.32%. Comparing base (818f9e5) to head (9bbbb00).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #52   +/-   ##
=======================================
  Coverage   75.32%   75.32%           
=======================================
  Files          59       59           
  Lines        1909     1909           
  Branches      494      469   -25     
=======================================
  Hits         1438     1438           
- Misses        468      469    +1     
+ Partials        3        2    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

asimonok
asimonok approved these changes Jul 12, 2024
View reviewed changes
Copy link
Collaborator

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl ready for review

mikhail-vl
mikhail-vl approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl mikhail-vl added the enhancement New feature or request label Jul 12, 2024
@mikhail-vl mikhail-vl added this to the Grafana Utils 1.4.0 milestone Jul 12, 2024
@mikhail-vl mikhail-vl merged commit b10ce35 into main Jul 12, 2024
1 check passed
@mikhail-vl mikhail-vl deleted the feat/update-find-field branch July 12, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asimonok asimonok asimonok approved these changes

@mikhail-vl mikhail-vl mikhail-vl approved these changes

Assignees

@vitPinchuk vitPinchuk

Labels
enhancement New feature or request
Projects
Business Suite
Archived in project
Milestone
Grafana Utils 1.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@vitPinchuk @codecov-commenter @asimonok @mikhail-vl